Change logging category to include TestProxy#6643
Merged
scbedd merged 7 commits intoAzure:mainfrom Aug 2, 2023
Merged
Conversation
JoshLove-msft
changed the title
JoshLove-msft
commented
Aug 2, 2023
| if (Logger == null && factory != null) | ||
| { | ||
| Logger = factory.CreateLogger("DebugLogging"); | ||
| Logger = factory.CreateLogger("Azure.Sdk.Tools.TestProxy"); |
Member
Author
There was a problem hiding this comment.
The generic CreateLogger<T> method doesn't work with static classes, so can't use:
CreateLogger<DebugLogger>()
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users to set an env var Logging__LogLevel__Azure.Sdk.Tools.TestProxy = "Debug" instead of changing the Default or DebugLogging category. Note changing Default will still work in the same way and I don't think we advertised "DebugLogging" to anyone so it hopefully won't break anyone. However, changing the Default log level would break tests in .NET since it would cause tests to start emitting logs.
By introducing a specific logging category (or more accurately renaming the specific logging category), we can let it still be configurable for users without requiring users to change the Default level.