Conversation
|
The following pipelines have been queued for testing: |
|
@danieljurek how much risk do you think we have here? |
|
I think this is OK to merge now as the mitigation for new spelling error detections is unchanged: If your PR is blocked, update the word list or fix your spelling errors. Upgrading the whole of cspell at once is the right way to do this instead of a subset of cspell's dependencies. I would rate this as relatively low risk because we've updated cspell in the past in response to problems and it hasn't resulted in catastrophic failures. The failures I'd be concerned about when doing this are:
Detailed testing of this change would have to be done on a per-repo basis as different languages scan at different levels of granularity: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/367/Capabilities-and-State |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6538 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Jeff Fisher <jeffish@microsoft.com>
|
Thanks @xirzec for starting this PR I took it through the sync process. |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6538 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Jeff Fisher <jeffish@microsoft.com>
To resolve some scan issues with old transitive deps.