Skip to content

Remove defunct template #6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2023
Merged

Remove defunct template #6248

merged 1 commit into from
May 26, 2023

Conversation

@JimSuplizio
Copy link
Contributor

@JimSuplizio JimSuplizio commented May 26, 2023

docs-metadata-release.yml was replaced with common/pipelines/templates/steps/update-docsms-metadata.yml and should have been removed at that time but was not.

@JimSuplizio JimSuplizio added EngSys This issue is impacting the engineering system. Docs labels May 26, 2023
@JimSuplizio JimSuplizio requested a review from danieljurek May 26, 2023 16:44
@JimSuplizio JimSuplizio self-assigned this May 26, 2023
@JimSuplizio JimSuplizio marked this pull request as ready for review May 26, 2023 16:44
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 26, 2023

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@danieljurek
Copy link
Member

danieljurek commented May 26, 2023

This file is ancient and not used anymore. Thanks!!

@weshaggard
Copy link
Member

weshaggard commented May 26, 2023

This file is ancient and not used anymore. Thanks!!

Are there other files related that should also be cleaned up?

This was referenced May 26, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@danieljurek
Copy link
Member

danieljurek commented May 26, 2023 •
edited
Loading

update-docs-metadata.ps1 referenced in this file is already removed. I think this template yml file was somehow missed in that earlier cleanup.

@JimSuplizio
Copy link
Contributor Author

JimSuplizio commented May 26, 2023

This file is ancient and not used anymore. Thanks!!

Are there other files related that should also be cleaned up?

Only the template yml file needs to be removed. The script the template was using, update-docs-metadata.ps1, was already removed.

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request May 26, 2023
@azure-sdk @JimSuplizio
Sync eng/common directory with azure-sdk-tools for PR 6248 (#26014)
c6c8818 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6248 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: James Suplizio <[email protected]>
@JimSuplizio JimSuplizio merged commit 26b96e7 into Azure:main May 26, 2023
@JimSuplizio JimSuplizio deleted the RemoveStaleTemplate branch May 26, 2023 18:36
minhanh-phan pushed a commit to minhanh-phan/azure-sdk-for-js that referenced this pull request Jun 12, 2023
@azure-sdk @JimSuplizio @minhanh-phan
Sync eng/common directory with azure-sdk-tools for PR 6248 (Azure#26014)
10149da 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6248 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: James Suplizio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieljurek danieljurek danieljurek approved these changes

@weshaggard weshaggard weshaggard approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

@benbp benbp Awaiting requested review from benbp

Assignees

@JimSuplizio JimSuplizio

Labels

Docs EngSys This issue is impacting the engineering system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JimSuplizio @azure-sdk @danieljurek @weshaggard