Fixes for uploading proxy logs#6230
Merged
Merged
Conversation
billwert
requested review from
benbp,
konrad-jamrozik and
weshaggard
as code owners
billwert
force-pushed
the
proxy-log-upload-fixes
branch
from
90d6264 to
d1b0ef2
Compare
benbp
approved these changes
May 24, 2023
Member
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced May 24, 2023
scbedd
pushed a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
May 24, 2023
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6230 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Bill Wert <billwert@microsoft.com>
minhanh-phan
pushed a commit
to minhanh-phan/azure-sdk-for-js
that referenced
this pull request
Jun 12, 2023
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6230 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Bill Wert <billwert@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
condition: succeededOrFailed()to the copy/delete steps so they run if there are earlier failures in the pipeline.