Skip to content

Conversation

@raych1
Copy link
Member

@raych1 raych1 commented May 23, 2023

  • Refine regex
  • Remove temp tspconfig.yaml
  • Use relative path as directory in tsplocation.yaml

@weshaggard , the third change is a fix of a bug and needs to get merged to unblock integration work with other languages.

@raych1 raych1 self-assigned this May 23, 2023
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion otherwise looks good.

@weshaggard
Copy link
Member

/azp run azure-sdk-tools - sync - eng-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member

/azp run azure-sdk-tools - sync - eng-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@raych1
Copy link
Member Author

raych1 commented May 29, 2023

/check-enforcer override

@raych1 raych1 merged commit 8d256dd into main May 29, 2023
@raych1 raych1 deleted the user/raych1/update-sdkgen-commonscript branch May 29, 2023 01:58
@weshaggard
Copy link
Member

@raych1 you did not follow the workflow process again. See directions at https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow. This is why your checks in your current PR are failing #6250

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request May 31, 2023
@raych1
Copy link
Member Author

raych1 commented May 31, 2023

@raych1 you did not follow the workflow process again. See directions at https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow. This is why your checks in your current PR are failing #6250

@weshaggard , sorry, I wasn't aware of this process. I found you helped on the previous PR sync to language repo. I just triggered the sync pipeline above and only one PR failed by other reason then I manually merge it.

@raych1 raych1 linked an issue Jun 1, 2023 that may be closed by this pull request
minhanh-phan pushed a commit to minhanh-phan/azure-sdk-for-js that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeSpec SDK generation common scripts implementation

5 participants