Skip to content

Move the cleanup config to -SaveInputs parameter on the cli#6197

Merged
m-nash merged 4 commits into
mainfrom
mnash-moveCleanUpToCli
May 22, 2023
Merged

Move the cleanup config to -SaveInputs parameter on the cli#6197
m-nash merged 4 commits into
mainfrom
mnash-moveCleanUpToCli

Conversation

@m-nash
Copy link
Copy Markdown
Member

@m-nash m-nash commented May 17, 2023 •
edited
Loading

Update the scripts to support this issue #6187

@m-nash m-nash requested review from a team, benbp, konrad-jamrozik and weshaggard as code owners May 17, 2023 21:30
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented May 17, 2023

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@m-nash m-nash mentioned this pull request May 17, 2023
Merged
@weshaggard weshaggard requested review from chunyu3 and raych1 May 17, 2023 22:24
weshaggard
weshaggard reviewed May 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me but I'll defer sign-off to @raych1 or @chunyu3.

@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented May 18, 2023

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

benbp
benbp reviewed May 18, 2023
View reviewed changes
Comment thread doc/common/Typespec-Project-Scripts.md Outdated
This was referenced May 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented May 22, 2023

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

m-nash added a commit to Azure/azure-sdk-for-js that referenced this pull request May 22, 2023
@azure-sdk @m-nash
Sync eng/common directory with azure-sdk-tools for PR 6197 (#25944)
1fb0d5a 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6197 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: m-nash <prognash@gmail.com>
@m-nash m-nash merged commit 591da95 into main May 22, 2023
@m-nash m-nash deleted the mnash-moveCleanUpToCli branch May 22, 2023 21:22
minhanh-phan pushed a commit to minhanh-phan/azure-sdk-for-js that referenced this pull request Jun 12, 2023
@azure-sdk @m-nash @minhanh-phan
Sync eng/common directory with azure-sdk-tools for PR 6197 (Azure#25944)
82e628e 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6197 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: m-nash <prognash@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbp benbp benbp left review comments

@weshaggard weshaggard weshaggard left review comments

@chunyu3 chunyu3 chunyu3 approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

@raych1 raych1 Awaiting requested review from raych1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@m-nash @azure-sdk @benbp @weshaggard @chunyu3