Add Azure.Sdk.Tools.NotificationConfiguration.Tests + improve NotificationConfiguration.Program.Main#5247
Merged
konrad-jamrozik merged 4 commits intomainfrom Jan 27, 2023
Merged
Conversation
…ationConfiguration.Program.Main
konrad-jamrozik
added
the
Central-EngSys
weshaggard
approved these changes
Jan 27, 2023
konrad-jamrozik
commented
Jan 27, 2023
tools/notification-configuration/notification-creator/Program.cs
Outdated
Show resolved
Hide resolved
konrad-jamrozik
commented
Jan 27, 2023
tools/notification-configuration/notification-creator/Program.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds most basic test for
Azure.Sdk.Tools.NotificationConfiguration.Program.Mainplus makes improvements to structure and logging inAzure.Sdk.Tools.NotificationConfiguration.Program.Main.This PR is a follow-up refactoring to:
Contactsclass + related refactorings toNotificationConfiguratorclass. #5214Please see that PR for more information on the wider context of this work.
A note on naming
The introduced project names are subject to change in upcoming PR:
notification-configuration#5089