notification-configuration: write out repo URL used to obtain CODEOWNERS file#5172
Merged
konrad-jamrozik merged 1 commit intomainfrom Jan 19, 2023
Merged
Conversation
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
changed the title
notification-configurator: write out repo URL used to obtain CODEOWNERS filenotification-configuration: write out repo URL used to obtain CODEOWNERS file
weshaggard
approved these changes
Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I am printing out to STDOUT the full URL of the repository from which the
CODEOWNERSfile is be parsed by thenotification-configurator.I need this because I am planning to make the
CODEOWNERSfile path matching logic to behave differently based on the repository from which the file is originating. This will enable me to do gradual rollout of the regex-based matcher.Details here: