-
Notifications
You must be signed in to change notification settings - Fork 235
[Perf] Refactor tests.yml into one file per package per language #5083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
863aab2
WIP: Support language+service input file
mikeharder c6839a2
Merge branch 'main' into perf-refactoring
mikeharder a2f8413
Merge branch 'main' into perf-refactoring
mikeharder 28ca85e
Merge branch 'main' into perf-refactoring
mikeharder f11fc29
Remove config file
mikeharder 4a6fc82
WIP: Remove unused options and code
mikeharder be82c5d
Merge branch 'main' into perf-refactoring
mikeharder 8d3dc3c
Merge branch 'main' into perf-refactoring
mikeharder a3705c8
WIP: Fix compile errors
mikeharder dfad556
Select tests and arguments
mikeharder dfecdad
Fix bug in package version filtering
mikeharder f19f693
Remove unused files
mikeharder 25b9984
Code cleanup
mikeharder 236dd6c
Remove unused code
mikeharder 2f67043
Remove language from profile zip
mikeharder 4ea6232
Remove config
mikeharder c2052f9
Revert "Remove language from profile zip"
mikeharder e1d18e3
Make RepoRoot required option
mikeharder e8a3553
Add default language versions
mikeharder 9f5b831
Copy PrimaryPackage
mikeharder d08ac90
Force NoSync=true for JS
mikeharder 453e390
Set NoAsync for Cpp
mikeharder fa1fc48
Merge branch 'main' into perf-refactoring
mikeharder 6ce5b16
Update default language versions
mikeharder 38298e7
Add HelpTest for TestsFile option
mikeharder 4980dfe
Remove Services parameter
mikeharder 0081cd1
Remove services parameter
mikeharder 0d9ce69
Fix path to tests-file
mikeharder 247b591
Revert "Add HelpTest for TestsFile option"
mikeharder d873545
Fix CppServiceDirectory
mikeharder 35f5cd5
Merge branch 'main' into perf-refactoring
mikeharder 0f1f10e
Run both sync and async tests by default
mikeharder 31a889a
Add LanguageVersion to common perf.yml
mikeharder af70d88
Throw if no LanguageVersion for .NET and Python
mikeharder 16f23f8
Add LanguageVersion parameter
mikeharder 48a9a01
Make LanguageVersion required
mikeharder 4df8279
Fix LanguageVersion for Python and C++
mikeharder d30d944
Merge branch 'main' into perf-refactoring
mikeharder 5b18f66
Merge branch 'main' into perf-refactoring
mikeharder 4493230
Merge branch 'main' into perf-refactoring
mikeharder dc6775e
Add values to NetLanguageVersion
mikeharder 572fe3e
Revert "Add values to NetLanguageVersion"
mikeharder e07e39a
Add displayName to LanguageVersion
mikeharder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 0 additions & 9 deletions
9
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/Models/Config.cs
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/Models/Input.cs
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/Models/LanguageInfo.cs
This file was deleted.
Oops, something went wrong.
37 changes: 35 additions & 2 deletions
37
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/Models/ServiceInfo.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,44 @@ | ||
| using System.Collections.Generic; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
|
|
||
| namespace Azure.Sdk.Tools.PerfAutomation.Models | ||
| { | ||
| public class ServiceInfo | ||
| { | ||
| public string Service { get; set; } | ||
| public IDictionary<Language, ServiceLanguageInfo> Languages { get; set; } | ||
| public string Project { get; set; } | ||
|
|
||
| private string _primaryPackage; | ||
| public string PrimaryPackage | ||
| { | ||
| get | ||
| { | ||
| if (!string.IsNullOrEmpty(_primaryPackage)) | ||
| { | ||
| return _primaryPackage; | ||
| } | ||
| else if (!PackageVersions.Any()) | ||
| { | ||
| return string.Empty; | ||
| } | ||
| else if (PackageVersions.First().Count == 1) | ||
| { | ||
| return PackageVersions.First().First().Key; | ||
| } | ||
| else | ||
| { | ||
| throw new InvalidOperationException("Must set PrimaryPackageVersion if PackageVersions contains multiple packages"); | ||
| } | ||
| } | ||
|
|
||
| set | ||
| { | ||
| _primaryPackage = value; | ||
| } | ||
| } | ||
|
|
||
| public IEnumerable<IDictionary<string, string>> PackageVersions { get; set; } | ||
| public IEnumerable<TestInfo> Tests { get; set; } | ||
| } | ||
| } |
38 changes: 0 additions & 38 deletions
38
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/Models/ServiceLanguageInfo.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is misleading. How about "fixture"? A common term across numerous languages' common test runners/frameworks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
Classis particularly misleading, since a perf test is represented by a class in each language. But I'm fine withFixtureas well.@AlexanderSher, @g2vinay, @HarshaNalluru, @timovv, @annatisch, @pvaneck, @gearama: Any opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixturesounds good, don't really mind either since this won't flow into the language repos anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chatted with @heaths, he is OK with
Classsince each perf test is represented by a class. He was thinking each perf test was represented by a method (like unit tests).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change would flow into the language repos, since it would also rename from
ClasstoFixturein all theperf-tests.ymlfiles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woah, ok