Update Ubuntu images in tools/sdk-generation-pipeline to Ubuntu 22.04#5004
Closed
konrad-jamrozik wants to merge 1 commit intomainfrom
Closed
Update Ubuntu images in tools/sdk-generation-pipeline to Ubuntu 22.04#5004konrad-jamrozik wants to merge 1 commit intomainfrom
tools/sdk-generation-pipeline to Ubuntu 22.04#5004konrad-jamrozik wants to merge 1 commit intomainfrom
Conversation
konrad-jamrozik
commented
Dec 21, 2022
tools/sdk-generation-pipeline to Ubuntu 22.04tools/sdk-generation-pipeline to Ubuntu 22.04
konrad-jamrozik
commented
Dec 21, 2022
dw511214992
reviewed
Dec 22, 2022
Contributor
Author
|
@dw511214992 @weshaggard I am closing this PR as "blocked". I created an issue for @dw511214992 to follow up when appropriate: Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a companion PR to:
In this PR, I migrate all occurrences of Ubuntu to
22.04in the directorytools/sdk-generation-pipeline.This PR is part of work on:
22.04intools/sdk-generation-pipeline#5178This PR requires review by @dw511214992, notably because of this comment:
@dw511214992 could you let me know what else needs to be done so that we can migrate
tools/sdk-generation-pipelineto Ubuntu 22.04? For example, how to migrate the docker image? Could I assist somehow with this? Note we want to do this migration to avoid issues like #4888 and get all the usual benefits on staying up to date with the newest image.Also please note this PR currently causes the build to fail on Go integration tests. I would appreciate any assistance with fixing this failure.