Migrate SkipDefaultCheckout to SkipCheckoutNone by benbp · Pull Request #4042 · Azure/azure-sdk-tools

benbp · 2022-08-31T20:50:18Z

Attempting to find a name for this parameter that causes less confusion

benbp · 2022-08-31T20:50:59Z

eng/common/pipelines/templates/steps/sparse-checkout.yml

      - Name: $(Build.Repository.Name)
        Commitish: $(Build.SourceVersion)
        WorkingDirectory: $(System.DefaultWorkingDirectory)
+  # NOTE: SkipDefaultCheckout is being deprecated in favor of SkipCheckoutNone


I'm keeping both to make it easier to do PRs one by one in the other repositories. After I'm done, I'll remove this parameter.

azure-sdk · 2022-08-31T20:56:07Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

scbedd

I originally was like

eugh

to the name. Then I read the variable, and I can't really hate anymore. It's definitely clearer now than it was.

ghost · 2022-09-01T20:47:11Z

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Migrate SkipDefaultCheckout to SkipCheckoutNone

19b91e4

benbp requested review from a team, sima-zhu and weshaggard as code owners August 31, 2022 20:50

benbp added the Central-EngSys This issue is owned by the Engineering System team. label Aug 31, 2022

benbp self-assigned this Aug 31, 2022

benbp requested review from JimSuplizio and scbedd August 31, 2022 20:50

benbp commented Aug 31, 2022

View reviewed changes

scbedd approved these changes Sep 1, 2022

View reviewed changes

azure-sdk added the auto-merge label Sep 1, 2022

ghost merged commit 32b98c1 into Azure:main Sep 1, 2022

benbp deleted the benbp/skip-checkout-none branch September 1, 2022 21:48

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate SkipDefaultCheckout to SkipCheckoutNone#4042

Migrate SkipDefaultCheckout to SkipCheckoutNone#4042
1 commit merged intoAzure:mainfrom
benbp:benbp/skip-checkout-none

benbp commented Aug 31, 2022

Uh oh!

benbp Aug 31, 2022

Uh oh!

azure-sdk commented Aug 31, 2022

Uh oh!

scbedd left a comment

Uh oh!

ghost commented Sep 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

benbp commented Aug 31, 2022

Uh oh!

benbp Aug 31, 2022

Choose a reason for hiding this comment

Uh oh!

azure-sdk commented Aug 31, 2022

Uh oh!

scbedd left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Sep 1, 2022

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.