Skip to content

Remove duplicate PR API review revisions #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenkuttappan merged 2 commits into from
Aug 16, 2022
Merged

Remove duplicate PR API review revisions #3949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2818e6d
Remove duplicate API reviews
praveenkuttappan Aug 16, 2022
c7deb5b
Update as per review comments
praveenkuttappan Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/dotnet/APIView/APIViewWeb/Models/ReviewRevisionModelList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ public void AddRange(IEnumerable<ReviewRevisionModel> revisionModels)
}
}

public void RemoveAll(System.Predicate<ReviewRevisionModel> match)
{
_list.RemoveAll(match);
}

public void Clear()
{
_list.Clear();
Expand Down
6 changes: 6 additions & 0 deletions src/dotnet/APIView/APIViewWeb/Repositories/PullRequestManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,12 @@ private async Task CreateRevisionIfRequired(CodeFile codeFile,
var prevRevisionId = review.Revisions.Last().RevisionId;
review = await GetBaseLineReview(codeFile.Language, codeFile.PackageName, pullRequestModel, true);
review.ReviewId = pullRequestModel.ReviewId;
//Remove previous revisions with revision ID.
//Currently revision ID is getting duplicated when a PR api review is created for a brand new package.
//In case of brand new package, we don't have any baseline from automatic review. So it uses previous PR api review as baseline and
//below revision ID copy step makes duplicate revision IDs in such cases.
//We should ensure that no revision exists in review with previous revision ID before we update new revision
review.Revisions.RemoveAll(r => r.RevisionId == prevRevisionId);
newRevision.RevisionId = prevRevisionId;
}
}
Expand Down