-
Notifications
You must be signed in to change notification settings - Fork 228
Refactor using implicit principal and vault based config #3751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1c6f7c5
Refactor using implicit principal and vault based config
hallipr 3fc485e
Cleanup logging and skipping logic in Processor. Use bulk github user…
hallipr 8aa2fce
Avoid using arrays with IConfiguration
hallipr 6388a03
Improve logging in GitHubToAADConverter and pipeline owner extractor
hallipr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
tools/identity-resolution/Models/OpenSourcePortal/AadUserDetail.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| namespace Models.OpenSourcePortal | ||
| { | ||
| public class AadUserDetail | ||
| { | ||
| public string Alias { get; set; } | ||
|
|
||
| public string PreferredName { get; set; } | ||
|
|
||
| public string UserPrincipalName { get; set; } | ||
|
|
||
| public string Id { get; set; } | ||
|
|
||
| public string EmailAddress { get; set; } | ||
| } | ||
| } |
13 changes: 13 additions & 0 deletions
13
tools/identity-resolution/Models/OpenSourcePortal/GitHubUserDetail.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| namespace Models.OpenSourcePortal | ||
| { | ||
| public class GitHubUserDetail | ||
| { | ||
| public int Id { get; set; } | ||
|
|
||
| public string Login { get; set; } | ||
|
|
||
| public string[] Organizations { get; set; } | ||
|
|
||
| public string Avatar { get; set; } | ||
| } | ||
| } |
13 changes: 13 additions & 0 deletions
13
tools/identity-resolution/Models/OpenSourcePortal/UserLink.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| namespace Models.OpenSourcePortal | ||
| { | ||
| public class UserLink | ||
| { | ||
| public GitHubUserDetail GitHub { get; set; } | ||
|
|
||
| public AadUserDetail Aad { get; set; } | ||
|
|
||
| public bool IsServiceAccount { get; set; } | ||
|
|
||
| public string ServiceAccountContact { get; set; } | ||
| } | ||
| } |
19 changes: 0 additions & 19 deletions
19
tools/pipeline-codeowners-extractor/Azure.Sdk.Tools.PipelineCodeownerExtractor.csproj
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this call get logged anywhere? Especially if someone is running this locally it might help to let them know what they are waiting on?