Skip to content

Detect API changes using pre-generated code file by CI approach#3735

Merged
5 commits merged intoAzure:mainfrom
praveenkuttappan:update_apiview_pr_check_script
Jul 25, 2022
Merged

Detect API changes using pre-generated code file by CI approach#3735
5 commits merged intoAzure:mainfrom
praveenkuttappan:update_apiview_pr_check_script

Conversation

@praveenkuttappan
Copy link
Member

Create API review from pull request using code file created by CI. APIView will use this approach instead of converting artifact to code file within server if review file name is passed as a parameter.

@praveenkuttappan praveenkuttappan requested review from scbedd and removed request for sima-zhu July 22, 2022 19:56
@praveenkuttappan praveenkuttappan self-assigned this Jul 22, 2022
@praveenkuttappan praveenkuttappan added the APIView Issues related to APIView core functionality or UI label Jul 22, 2022
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

[string] $TargetBranch = ("origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH}" -replace "refs/heads/")
)

Set-StrictMode -version 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you do some validation after you enable this as it can cause your script to start failing in various ways.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Jul 25, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 7ba34eb into Azure:main Jul 25, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APIView Issues related to APIView core functionality or UI

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants