Skip to content

Add runtime assignment of SkipCheckingForChanges#3683

Closed
danieljurek wants to merge 1 commit intomainfrom
djurek/git-push-changes
Closed

Add runtime assignment of SkipCheckingForChanges#3683
danieljurek wants to merge 1 commit intomainfrom
djurek/git-push-changes

Conversation

@danieljurek
Copy link
Member

@danieljurek danieljurek commented Jul 18, 2022

This change came from a failure in C++. We're representing SkipCheckingForChanges in git-push-changes.yml in a way that only accepts values of true or false specified at compile time for the template.

With these changes we can now evaluate inputs of true, false, and variable['VariableName'] to support scenarios where whether we should open a PR is evaluated at runtime.

From searching other repositories, C++ is the only repo which uses SkipCheckingForChanges ... No other repos appear to use it according to my grep'ing of android, c, cpp, go, ios, java, js, net, and python repos.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@danieljurek
Copy link
Member Author

This change is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants