Add runtime assignment of SkipCheckingForChanges#3683
Closed
danieljurek wants to merge 1 commit intomainfrom
Closed
Add runtime assignment of SkipCheckingForChanges#3683danieljurek wants to merge 1 commit intomainfrom
danieljurek wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
The following pipelines have been queued for testing: |
Member
Author
|
This change is not necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change came from a failure in C++. We're representing
SkipCheckingForChangesingit-push-changes.ymlin a way that only accepts values oftrueorfalsespecified at compile time for the template.With these changes we can now evaluate inputs of
true,false, andvariable['VariableName']to support scenarios where whether we should open a PR is evaluated at runtime.From searching other repositories, C++ is the only repo which uses
SkipCheckingForChanges... No other repos appear to use it according to my grep'ing of android, c, cpp, go, ios, java, js, net, and python repos.