Skip to content

[Test-Proxy] Allow eng/common/testproxy to be used via external reference#3656

Merged
2 commits merged intoAzure:mainfrom
scbedd:hotfix/adjustable-repo-root
Jul 15, 2022
Merged

[Test-Proxy] Allow eng/common/testproxy to be used via external reference#3656
2 commits merged intoAzure:mainfrom
scbedd:hotfix/adjustable-repo-root

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Jul 15, 2022

@iscai-msft is hitting issues when running tests just prior to autorest release. As part of that release verification, they need to run storage against the latest version just prior to release. Now that storage uses test-proxy, that is breaking in their pipeline.

To enable this, I originally referred @iscai-msft to pull in the repo using

resources:
  repositories:
    - repository: azure-sdk-tools
      type: git
      name: Azure/azure-sdk-tools
      ref: refs/heads/main

But they can't simply activate the template, because the template assumes that it is in the original $(Build.SourcesDirectory). This PR just backs that assumption out, without changing anything if you don't provide an argument.

… to make this easy on them we're parameterizing the root of the eng/common for easy use in that scenario
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member

benbp commented Jul 15, 2022

Is the issue here that it's being run from a repo without eng/common syncing?

@scbedd
Copy link
Member Author

scbedd commented Jul 15, 2022

Yeah. The autorest repo specifically in this case.

@benbp
Copy link
Member

benbp commented Jul 15, 2022

Merging to unblock but we should chat more about this reference going forwards and whether we want to pin versions (to make historical builds more reliable if necessary).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd
Copy link
Member Author

scbedd commented Jul 15, 2022

Given that a lot of the template pipelines don't exercise test-proxy, I manually queued one. It checks out. I have filed an issue to enforce that.

@ghost
Copy link

ghost commented Jul 15, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit e013528 into Azure:main Jul 15, 2022
@weshaggard
Copy link
Member

ref: refs/heads/main

We should be using tags for external repo and we should do a release of the tools repo by running https://dev.azure.com/azure-sdk/internal/_build?definitionId=1696&_a=summary and if you want a repo reference to be updated you need to add the repo to the list at https://github.com/Azure/azure-sdk-tools/blob/main/eng/pipelines/tools-repo-versioning.yml#L26

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants