[testresources] String parsing improvements to service directory resource names#3323
Merged
benbp merged 1 commit intoAzure:mainfrom May 12, 2022
Merged
[testresources] String parsing improvements to service directory resource names#3323benbp merged 1 commit intoAzure:mainfrom
benbp merged 1 commit intoAzure:mainfrom
Conversation
benbp
added
the
Central-EngSys
Collaborator
|
The following pipelines have been queued for testing: |
heaths
approved these changes
May 11, 2022
mikeharder
added a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
May 11, 2022
This was referenced May 11, 2022
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These updates allow us to handle service directory parameters like
storage/Azure.Storage.Blobs. The perf test ARM templates need to reside in directories like this. I also shortened the service name generation in local usage to only use the leaf directory name to avoid naming length restrictions with some resource types (e.g. storage).