Skip to content

Skip azcopy download if it already exists#3188

Merged
1 commit merged intomainfrom
pahallis/idempotent-azcopy-downlaod
Apr 21, 2022
Merged

Skip azcopy download if it already exists#3188
1 commit merged intomainfrom
pahallis/idempotent-azcopy-downlaod

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Apr 21, 2022

No description provided.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 21, 2022

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

JimSuplizio
JimSuplizio approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this Patrick.

This was referenced Apr 21, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@scbedd
Copy link
Member

scbedd commented Apr 21, 2022

🚀 🚀 🚀

@ghost
Copy link

ghost commented Apr 21, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit f14aa77 into main Apr 21, 2022
@ghost ghost deleted the pahallis/idempotent-azcopy-downlaod branch April 21, 2022 22:03
weshaggard
weshaggard reviewed Apr 26, 2022
View reviewed changes
eng/common/pipelines/templates/steps/publish-blobs.yml
- pwsh: |
Invoke-WebRequest -MaximumRetryCount 10 -Uri "https://aka.ms/downloadazcopy-v10-windows" -OutFile "azcopy.zip" | Wait-Process;
Expand-Archive -Path "azcopy.zip" -DestinationPath "$(Build.BinariesDirectory)/azcopy/"
if (!(Test-Path '$(Build.BinariesDirectory)/azcopy/azcopy_windows_amd64_*/azcopy.exe')) {
Copy link
Member

@weshaggard weshaggard Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this will likely help the immediate issue, we can probably improve this a little further by checking to see if azcopy is already on the path via gcm because I believe it is already on the agents now.

benbp pushed a commit to benbp/azure-sdk-tools that referenced this pull request May 6, 2022
@hallipr @benbp
Skip azcopy download if it already exists (Azure#3188)
e5d3d80
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard left review comments

@benbp benbp benbp approved these changes

@sima-zhu sima-zhu Awaiting requested review from sima-zhu

+1 more reviewer

@JimSuplizio JimSuplizio JimSuplizio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hallipr @azure-sdk @scbedd @benbp @weshaggard @JimSuplizio