Skip to content

Add timeout on Invoke-request call #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Feb 18, 2022
Merged

Add timeout on Invoke-request call #2768

1 commit merged into from
Feb 18, 2022
+9 −5

Conversation

@sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Feb 16, 2022 •
edited
Loading

Add timeout on all web request call.
This is for the issue: #2600

@sima-zhu sima-zhu self-assigned this Feb 16, 2022
@sima-zhu sima-zhu added Central-EngSys This issue is owned by the Engineering System team. Docs labels Feb 16, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 16, 2022

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

weshaggard commented Feb 16, 2022

@sima-zhu I think there is an issue associated with this fix. Can you please link to it in the description?

weshaggard
weshaggard reviewed Feb 16, 2022
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 16, 2022

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

benbp
benbp reviewed Feb 16, 2022
View reviewed changes
benbp
benbp approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doc spelling nit, but +1 after that.

@sima-zhu sima-zhu requested a review from weshaggard February 16, 2022 20:23
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 16, 2022

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Feb 16, 2022
View reviewed changes
weshaggard
weshaggard reviewed Feb 16, 2022
View reviewed changes
weshaggard
weshaggard approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions but otherwise looks good.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 18, 2022

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Feb 18, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Feb 18, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 4fcec2c into Azure:main Feb 18, 2022
@sima-zhu sima-zhu deleted the fix_timeout branch February 18, 2022 06:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbp benbp benbp approved these changes

@weshaggard weshaggard weshaggard approved these changes

Assignees

@sima-zhu sima-zhu

Labels

Central-EngSys This issue is owned by the Engineering System team. Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sima-zhu @azure-sdk @weshaggard @benbp