fix incidentally added path addition #2604
Conversation
|
The following pipelines have been queued for testing: |
| $fileName = ($serviceName -replace '\s', '').ToLower().Trim() | ||
| # handle spaces in service name, EG "Confidential Ledger" | ||
| # handle / in service name, EG "Database for MySQL/PostgreSQL". Leaving a "/" present will generate a bad link location. | ||
| $fileName = ($serviceName -replace '\s', '').Replace("/","").ToLower().Trim() |
There was a problem hiding this comment.
@danieljurek it looks like we might want to start having some helper for this as we are doing this in a few places.
There was a problem hiding this comment.
Can we put check into one regex?
$serviceName -replace "\s|\\|\/, ""
There was a problem hiding this comment.
I had already merged this in a few repos before this feedback came in. I'm going to merge this PR.
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/check-enforcer override |
ghost
merged commit 4 participants
@sima-zhu I was investigating Azure/azure-sdk-for-python#16794 and discovered this.
In the case where there is a "/" in the name it gets used directly! This means on a browser that the link to the landing page won't ever render because a
/means "next folder in" on a webserver!So for the service
Database for MySQL/PostGreSQL, this turns into pathdatabaseformysql/postgresql.html. This is 404ing.