Conversation
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
Do we need a full script for this? Would a simple helper method similar to https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1#L6 do the job? |
sima-zhu
changed the title
|
The following pipelines have been queued for testing: |
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
|
The following pipelines have been queued for testing: |
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
| } | ||
|
|
||
| $resp | Write-Verbose | ||
|
|
There was a problem hiding this comment.
It might be worth adding some logging of what value we got back so it shows up in the logs something like this in the if statement:
Write-Host "Fetched aad identity $($resp.aad.alias) for github user $GithubName
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
One last comment but looks good otherwise.
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 4 participants
Summary:
The PR is using opensource rest API call to get ms alias from github identity. Generate aad token from service principle.
Expect returns:
Return ms alias directly when call the scripts.
Print the API call error response and exit 1.
Testing locally