Removing duplicated env:USER in image tag for stress test#2578
Conversation
ckairen
added
the
Central-EngSys
|
The following pipelines have been queued for testing: |
| $imageTag += "/$repositoryBase" | ||
| } | ||
| $imageTag += "/$($pkg.Namespace)/$($pkg.ReleaseName):${deployId}" | ||
| if ($pkg.Namespace -ne $repositoryBase) { |
There was a problem hiding this comment.
I think it would be better to fix the issue at the root in find-all-stress-packages since that's where the context of how we should set these values lives (i.e. whether to use the username or the chart metadata). Perhaps exposing another property like $pkg.ImageRepository and setting that alongside the other "is local user mode" conditionals could work?
There was a problem hiding this comment.
One problem I can see with this approach is that we would have a less predictable naming structure for prod environments, e.g. if a user adds a release name X that happens to match the namespace X, I don't think we'd want to end up putting that image in the parent repository X and breaking the organizational structure.
|
The following pipelines have been queued for testing: |
benbp
added
the
Stress
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 3 participants
No description provided.