Skip to content

Conversation

@praveenkuttappan
Copy link
Member

New API to get list of github issues based on labels and created user name. This API will be consumed by JS automation to file an issue for package deprecation and upgrade available warning if not already exists.

@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Dec 8, 2021
@praveenkuttappan praveenkuttappan self-assigned this Dec 8, 2021
@praveenkuttappan praveenkuttappan requested a review from a team as a code owner December 8, 2021 18:49
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

-MaximumRetryCount 3
}

function Get-GitHubIssues {
Copy link
Contributor

@sima-zhu sima-zhu Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use this API to get all issues with particular labels?

If so, can we have the right API name to indicate it is about labels as it is required parameters?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add comments on what is the format for multi-labels?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer to have this as a single API that can support different level of filtering. Adding label to name will make it more specific than a general API. Currently implementation is based on label and creator but this can be enhanced to make them optional and support more query options.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If support multi filters in this API, can we make labels as optional as well? Otherwise, people has no way to use this for authors only or for assignees only. It is currently working so specific for particular purpose.

@ghost
Copy link

ghost commented Dec 8, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit a31d9fb into Azure:main Dec 8, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants