Skip to content

Add group id into metadata for java use #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sima-zhu merged 5 commits into from
Oct 19, 2021
Merged

Add group id into metadata for java use #2100

sima-zhu merged 5 commits into from
Oct 19, 2021

Conversation

@sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Oct 14, 2021

Java daily updates needs group id to download the required package. The group id is missing from azure-sdk-tool script Update-DocMsPackage.ps1. The PR is to add it back.
Test update in daily branch:
https://github.com/Azure/azure-docs-sdk-java/blob/daily/2021-10-14/package.json#L1762

@sima-zhu sima-zhu requested a review from a team as a code owner October 14, 2021 05:35
@sima-zhu sima-zhu requested review from danieljurek and weshaggard and removed request for a team October 14, 2021 05:35
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 14, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Oct 14, 2021
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 14, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

benbp
benbp reviewed Oct 14, 2021
View reviewed changes
benbp
benbp reviewed Oct 14, 2021
View reviewed changes
@sima-zhu sima-zhu requested review from benbp and weshaggard October 18, 2021 16:43
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 18, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Oct 18, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sima-zhu sima-zhu merged commit 85cfe54 into Azure:main Oct 19, 2021
@sima-zhu sima-zhu deleted the updatedocmspkg branch October 19, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbp benbp benbp approved these changes

@weshaggard weshaggard weshaggard approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sima-zhu @azure-sdk @benbp @weshaggard