Skip to content

Clean-up changelog scripts #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Sep 22, 2021
Merged

Clean-up changelog scripts #2025

1 commit merged into from
Sep 22, 2021

Conversation

@weshaggard
Copy link
Member

@weshaggard weshaggard commented Sep 22, 2021

No description provided.

@weshaggard weshaggard requested a review from a team as a code owner September 22, 2021 00:05
weshaggard
weshaggard commented Sep 22, 2021
View reviewed changes
eng/common/scripts/Update-ChangeLog.ps1
if ($ChangeLogEntries[$Version].ReleaseStatus -eq $ReleaseStatus)
{
LogWarning "Version [$Version] is already present in change log with specificed ReleaseStatus [$ReleaseStatus]. No Change made."
LogDebug "Version [$Version] is already present in change log with specificed ReleaseStatus [$ReleaseStatus]. No Change made."
Copy link
Member Author

@weshaggard weshaggard Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These warnings in some common scenarios are outputting warnings which aren't interesting so turning these into debug logging instead of warning.

@weshaggard
Copy link
Member Author

weshaggard commented Sep 22, 2021

FYI @weidongxu-microsoft this should eliminate all the changelog warnings you are seeing in java.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 22, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Sep 22, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Sep 22, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 4df53a2 into Azure:main Sep 22, 2021
@weshaggard
Copy link
Member Author

weshaggard commented Sep 22, 2021

Thanks for getting this merged @chidozieononiwu

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chidozieononiwu chidozieononiwu chidozieononiwu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weshaggard @azure-sdk @chidozieononiwu