Skip to content

Update Article Type for Docs.MS Doc Updates #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Jul 22, 2021
Merged

Update Article Type for Docs.MS Doc Updates #1827

2 commits merged into from
Jul 22, 2021

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Jul 20, 2021

No description provided.

@scbedd scbedd requested a review from a team as a code owner July 20, 2021 18:26
@scbedd scbedd requested a review from danieljurek July 20, 2021 18:27
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 20, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

danieljurek
danieljurek reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/scripts/Update-DocsMsMetadata.ps1#L87

@scbedd
Copy link
Member Author

scbedd commented Jul 20, 2021

@danieljurek am I crazy? I did!

@danieljurek
Copy link
Member

danieljurek commented Jul 20, 2021

I meant https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/scripts/update-docs-metadata.ps1#L74

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 20, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd scbedd self-assigned this Jul 22, 2021
@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Jul 22, 2021
This was referenced Jul 22, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Jul 22, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@scbedd
Copy link
Member Author

scbedd commented Jul 22, 2021

The check on eng-common is taking a bit to come back. It has run successfully.

image

Overriding check-enforcer.

@scbedd
Copy link
Member Author

scbedd commented Jul 22, 2021

/check-enforcer override

@ghost ghost merged commit 11f1776 into Azure:main Jul 22, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieljurek danieljurek danieljurek approved these changes

Assignees

@scbedd scbedd

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scbedd @azure-sdk @danieljurek