Skip to content

Conversation

@benbp
Copy link
Member

@benbp benbp commented Jul 1, 2021

This will make it easier to build out weekly pipeline tests where needed.

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Jul 1, 2021
@benbp benbp requested a review from weshaggard July 1, 2021 19:52
@benbp benbp self-assigned this Jul 1, 2021
@benbp benbp requested a review from a team as a code owner July 1, 2021 19:52
@check-enforcer-staging
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/prepare-pipelines-weekly branch from 428e154 to dadafb3 Compare July 2, 2021 01:21
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member Author

benbp commented Jul 2, 2021

/check-enforcer override

@benbp
Copy link
Member Author

benbp commented Jul 7, 2021

@weshaggard I hadn't thought about this before, but we should also disable the weekly pipelines by default, since currently this will auto-create a lot of pipelines that we don't expect to pass due to lack of sovereign testing support.

@weshaggard
Copy link
Member

Maybe we should figure out some way of sharing this configuration with https://github.com/Azure/azure-sdk-tools/blob/main/eng/pipelines/pipeline-generation.yml so that we can control the option at a language level, or maybe even figure out a way to control it at the pipeline level.

@benbp
Copy link
Member Author

benbp commented Jul 7, 2021

Pipeline level control would be pretty hard as we'd need to parse all the yaml files, or keep some external configuration in sync.

Perhaps instead we could have a separate pipeline like prepare-weekly-pipeline that does a diff check against the service directories with tests.yml changes, and only initializes those?

@weshaggard
Copy link
Member

We already have the repo and yml file paths so perhaps a quick grep of content in the tests.yml file looking for some configuration could work if we wanted folks to opt-in or opt-out in some way.

I'm not opposed to another pipeline for the weekly tests but if we can avoid it we should try because on-boarding is already difficult enough without adding more steps that folks don't know if or when they need to run.

@benbp
Copy link
Member Author

benbp commented Jan 5, 2022

Closing in favor of #2484 which builds out weekly pipelines by default for all SDKs.

@benbp benbp closed this Jan 5, 2022
@benbp benbp deleted the benbp/prepare-pipelines-weekly branch January 5, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants