-
Notifications
You must be signed in to change notification settings - Fork 229
Add tests-weekly convention to prepare pipelines template #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: |
|
The following pipelines have been queued for testing: |
428e154 to
dadafb3
Compare
|
The following pipelines have been queued for testing: |
|
/check-enforcer override |
|
@weshaggard I hadn't thought about this before, but we should also disable the weekly pipelines by default, since currently this will auto-create a lot of pipelines that we don't expect to pass due to lack of sovereign testing support. |
|
Maybe we should figure out some way of sharing this configuration with https://github.com/Azure/azure-sdk-tools/blob/main/eng/pipelines/pipeline-generation.yml so that we can control the option at a language level, or maybe even figure out a way to control it at the pipeline level. |
|
Pipeline level control would be pretty hard as we'd need to parse all the yaml files, or keep some external configuration in sync. Perhaps instead we could have a separate pipeline like |
|
We already have the repo and yml file paths so perhaps a quick grep of content in the tests.yml file looking for some configuration could work if we wanted folks to opt-in or opt-out in some way. I'm not opposed to another pipeline for the weekly tests but if we can avoid it we should try because on-boarding is already difficult enough without adding more steps that folks don't know if or when they need to run. |
|
Closing in favor of #2484 which builds out weekly pipelines by default for all SDKs. |
This will make it easier to build out weekly pipeline tests where needed.