Skip to content

eng/common changes for docs metadata release #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5 commits merged into from
Jun 30, 2021
Merged

eng/common changes for docs metadata release #1725

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef6d86f
Bring changes from JS docs metadata
danieljurek Jun 22, 2021
ed81079
Move business logic inside Update-DocsMsMetadata.ps1
danieljurek Jun 22, 2021
f9f57b7
Update with the latest changes in JS PR
danieljurek Jun 28, 2021
09a6afc
Update from latest PR feedback
danieljurek Jun 29, 2021
44526d9
Add check for empty path to prevent crashes when creating relative paths
danieljurek Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eng/common/scripts/Save-Package-Properties.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ function SetOutput($outputPath, $incomingPackageSpec) {
}

function GetRelativePath($path) {
# If the path is empty return an empty string
Copy link
Member

@weshaggard weshaggard Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a case where we are validly passing empty here?

Copy link
Member Author

@danieljurek danieljurek Jun 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this instance Azure.Core.TestFramework does not have a CHANGELOG.md https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/core/Azure.Core.TestFramework

In previous builds this would have produced output like:

{
  "Name": "Azure.Core.TestFramework",
  "Version": "",
  "DirectoryPath": "D:\\a\\_work\\1\\s\\sdk\\core\\Azure.Core.TestFramework",
  "ServiceDirectory": "core",
  "ReadMePath": "D:\\a\\_work\\1\\s\\sdk\\core\\Azure.Core.TestFramework\\README.md",
  "ChangeLogPath": "",
  "Group": null,
  "SdkType": "client",
  "IsNewSdk": true,
  "ArtifactName": "Azure.Core.TestFramework",
  "ReleaseStatus": null
}

if (!$path) {
return ''
}
$relativeTo = Resolve-Path $PSScriptRoot/../../../
# Replace "\" with "/" so the path is valid across other platforms and tools
$relativePath = [IO.Path]::GetRelativePath($relativeTo, $path) -replace "\\", '/'
Expand Down