Skip to content

Strict mode needs the variables initialized #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jun 10, 2021
Merged

Strict mode needs the variables initialized #1685

1 commit merged into from
Jun 10, 2021

Conversation

@weshaggard
Copy link
Member

@weshaggard weshaggard commented Jun 10, 2021

Fixes #1682

@weshaggard weshaggard requested a review from a team as a code owner June 10, 2021 00:40
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 10, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard weshaggard force-pushed the InitializeChangeLogVariables branch from ea39109 to f9cecc3 Compare June 10, 2021 00:52
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 10, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jun 10, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
srnagar
srnagar approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @weshaggard

@ghost
Copy link

ghost commented Jun 10, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 30dd4b0 into Azure:master Jun 10, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chidozieononiwu chidozieononiwu chidozieononiwu approved these changes

@srnagar srnagar srnagar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prepare-Release can't update the changelog

4 participants

@weshaggard @azure-sdk @chidozieononiwu @srnagar