Skip to content

Make eng folder optional in sparse-checkout.yml#1556

Closed
scbedd wants to merge 2 commits intoAzure:masterfrom
scbedd:hotfix/sparse-checkout-without-eng
Closed

Make eng folder optional in sparse-checkout.yml#1556
scbedd wants to merge 2 commits intoAzure:masterfrom
scbedd:hotfix/sparse-checkout-without-eng

Conversation

@scbedd
Copy link
Copy Markdown
Member

@scbedd scbedd commented Apr 14, 2021

Comment here has context as to why I'm submitting this PR.

@scbedd scbedd requested a review from a team as a code owner April 14, 2021 17:46
@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd scbedd force-pushed the hotfix/sparse-checkout-without-eng branch from 91b0919 to 3127134 Compare April 14, 2021 18:07
@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Copy Markdown
Member

benbp commented Apr 14, 2021

See Azure/azure-sdk-for-python#16667 (comment). I think preferring to use /* which seems to be the "all" glob convention for sparse-checkout is a better approach here, rather than adding another conditional.

Default sparse-checkout file on init, which includes all top level files and excludes sub-directories (so we'll just take the first line):

⇉ ⇉ ⇉ cat .git/info/sparse-checkout
/*
!/*/

@scbedd
Copy link
Copy Markdown
Member Author

scbedd commented Apr 14, 2021

@benbp agree. I tried it with the pattern and it def works.

@scbedd scbedd closed this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants