Skip to content

Onboarding branch needs to delete the step of updating target ci#1552

Merged
2 commits merged intoAzure:masterfrom
sima-zhu:fix_bug_update_ci
Apr 13, 2021
Merged

Onboarding branch needs to delete the step of updating target ci#1552
2 commits merged intoAzure:masterfrom
sima-zhu:fix_bug_update_ci

Conversation

@sima-zhu
Copy link
Copy Markdown
Contributor

@sima-zhu sima-zhu commented Apr 13, 2021

@sima-zhu sima-zhu requested a review from a team as a code owner April 13, 2021 00:08
@sima-zhu sima-zhu requested review from weshaggard and removed request for a team April 13, 2021 00:09
pwsh: true
env:
GH_TOKEN: $(azuresdk-github-pat)
- template: /eng/common/pipelines/templates/steps/git-push-changes.yml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the other steps needed after removing this? I suspect the others will always be a noop now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieljurek Is the onboarding branch still needed once we want to update the package list from release csv?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing in .NET template

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sima-zhu sima-zhu requested a review from danieljurek April 13, 2021 00:18
@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@sima-zhu sima-zhu requested a review from weshaggard April 13, 2021 05:10
Copy link
Copy Markdown
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you have finished testing the change looks good.

@ghost
Copy link
Copy Markdown

ghost commented Apr 13, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6a808c8 into Azure:master Apr 13, 2021
@sima-zhu sima-zhu deleted the fix_bug_update_ci branch April 13, 2021 18:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants