Skip to content

Add DependsOn parameter to matrix job generation template #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Mar 30, 2021
Merged

Add DependsOn parameter to matrix job generation template #1527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eng/common/pipelines/templates/jobs/archetype-sdk-tests-generate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
parameters:
- name: AdditionalParameters
type: object
- name: DependsOn
type: object
default: null
Copy link
Copy Markdown
Member

@weshaggard weshaggard Mar 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is null a valid value? I don't see it mentioned anywhere at https://docs.microsoft.com/en-us/azure/devops/pipelines/process/templates?view=azure-devops. Should we just leave this as empty instead?

Copy link
Copy Markdown
Member Author

@benbp benbp Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The challenge I'm having is that leaving it empty marks it as a required parameter, but defaulting it to [] means my ${{ if ... }} conditional won't work. Perhaps there's a better way?

Copy link
Copy Markdown
Member

@weshaggard weshaggard Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just set it to '' and then compare against that string in your condition?

Copy link
Copy Markdown
Member Author

@benbp benbp Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But to your main question, it does work when empty. My understanding is it's a yaml object type, which I assume is a JSON object type, for which null is a valid field.

Copy link
Copy Markdown
Member

@weshaggard weshaggard Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it works in your testing I'm fine with this approach I just haven't seen it before and couldn't find any reference to null in the docs.

- name: CloudConfig
type: object
default: {}
Expand Down Expand Up @@ -37,6 +40,8 @@ jobs:
name: ${{ parameters.Pool }}
vmImage: ${{ parameters.OsVmImage }}
displayName: Generate Job Matrix
${{ if parameters.DependsOn }}:
dependsOn: ${{ parameters.DependsOn }}
steps:
# Skip sparse checkout for the `azure-sdk-for-<lang>-pr` private mirrored repositories
# as we require the github service connection to be loaded.
Expand Down