Skip to content

Fix bug in Changelog URL path using packageDirectoryName#1485

Merged
chidozieononiwu merged 1 commit intoAzure:masterfrom
chidozieononiwu:CollectChangeLog
Mar 12, 2021
Merged

Fix bug in Changelog URL path using packageDirectoryName#1485
chidozieononiwu merged 1 commit intoAzure:masterfrom
chidozieononiwu:CollectChangeLog

Conversation

@chidozieononiwu
Copy link
Member

This fix ensure that ChangelogUrl is correct for JS (as well as Java, Python, and dotnet)

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner March 11, 2021 20:20
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work for now but we might want to think about sharing the link template we use in other places.

@chidozieononiwu
Copy link
Member Author

/check-enforcer override

@chidozieononiwu chidozieononiwu merged commit e3e5f4e into Azure:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants