Sort changelogs by date then version #1479
Conversation
|
The following pipelines have been queued for testing: |
| #> | ||
|
|
||
| class AzureEngSemanticVersion { | ||
| class AzureEngSemanticVersion : IComparable { |
There was a problem hiding this comment.
Thanks for adding this I've been wanting to do that for a while.
cc @danieljurek as I know he was also looking at potentially doing this.
There was a problem hiding this comment.
This is a much better (more readable) version than the one I wrote. I vote we use this one. Did some local sanity checking and this implementation checks out.
There was a problem hiding this comment.
Initially I tried implementing the generic IComparable[AzureEngSemanticVersion] interface, but seems you can't do that in PowerShell given the order of when types are resolved vs. compiled.
| return $versions | Sort-Object -Descending | ||
| } | ||
|
|
||
| static [void] QuickTests() |
There was a problem hiding this comment.
If you haven't already could you please do a quick run of this to make sure the basic tests we have still work the same?
There was a problem hiding this comment.
I did, yes. In fact, I had to to debug an issue I was having in the original iteration.
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Thanks for fixing this @heaths.
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
|
@weshaggard @chidozieononiwu @danieljurek should I send out an email about this, and make sure people know to add (preferably accurate) dates for older versions in their changelogs? |
|
I don't think it is worth sending an email as most folks will ignore it. If there are any issues they will come to light in the version increment PRs. |
4 participants
Fixes #1389