Skip to content

[Test Resources] Add ArmTemplateParameters to global variable #14697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minhanh-phan wants to merge 2 commits into from
Closed

[Test Resources] Add ArmTemplateParameters to global variable #14697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9443505
add missing variable
minhanh-phan Mar 24, 2026
b64ba46
Merge branch 'main' into fixArmTemplate
minhanh-phan Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/common/TestResources/New-TestResources.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,7 @@ $serialized
# Set global variables that aren't always passed as parameters
`$ResourceGroupName = `$parameters.ResourceGroupName
`$AdditionalParameters = `$parameters.AdditionalParameters
`$ArmTemplateParameters = `$parameters.ArmTemplateParameters

@benbp benbp Mar 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying over from https://github.com/Azure/azure-sdk-for-js/pull/37736/changes#r2989926543

What is currently done in other comparable tests is that post-script inspects the arm template deployment outputs only. I think this is a better approach because it reduces any coupling on parameters/variables that have to be consistently named and passed across yaml, powershell and arm/bicep files. For example: https://github.com/Azure/azure-sdk-for-net/blob/0acbe6a297f69e026e78a93ba6df1bf89af866a0/sdk/keyvault/test-resources-post.ps1#L36-L39

When I selected the parameters to copy over I only picked ones that were actively used across all our post scripts. I originally didn't include AdditionalParameters either until an earlier iteration of js identity, but we can probably remove it now as well.

`$DeploymentOutputs = `$parameters.DeploymentOutputs
$postDeploymentScript `@parameters
Comment thread
minhanh-phan marked this conversation as resolved.
"@
Expand Down