Skip to content

Fix bug where imported matrix parameter duplicates are not overrided#1461

Merged
1 commit merged intoAzure:masterfrom
benbp:benbp/matrix-import-override-fix
Mar 5, 2021
Merged

Fix bug where imported matrix parameter duplicates are not overrided#1461
1 commit merged intoAzure:masterfrom
benbp:benbp/matrix-import-override-fix

Conversation

@benbp
Copy link
Member

@benbp benbp commented Mar 4, 2021

When importing a matrix from another matrix, the intended behavior is that any duplicate parameter keys favor the value in the matrix doing the import. This PR fixes a bug where this did not happen (instead the imported matrix's value is favored).

@benbp benbp requested a review from a team as a code owner March 4, 2021 18:16
@benbp
Copy link
Member Author

benbp commented Mar 4, 2021

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp self-assigned this Mar 4, 2021
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Mar 4, 2021
@benbp benbp requested a review from weshaggard March 4, 2021 23:09
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@ghost
Copy link

ghost commented Mar 5, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c9b5add into Azure:master Mar 5, 2021
@benbp benbp deleted the benbp/matrix-import-override-fix branch March 5, 2021 21:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants