Skip to content

[eng/common] Add .gitignore for node_modules#14227

Merged
mikeharder merged 2 commits intoAzure:mainfrom
mikeharder:eng-common-gitignore
Feb 28, 2026
Merged

[eng/common] Add .gitignore for node_modules#14227
mikeharder merged 2 commits intoAzure:mainfrom
mikeharder:eng-common-gitignore

Conversation

@mikeharder
Copy link
Member

@mikeharder mikeharder commented Feb 27, 2026

  • prevents node_modules in subfolders (tsp-client, spelling) from being tracked by git in consuming repos

Copilot AI review requested due to automatic review settings February 27, 2026 23:07
@mikeharder mikeharder requested a review from a team as a code owner February 27, 2026 23:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a scoped .gitignore under eng/common to prevent Node.js dependency folders from being accidentally committed when eng/common is consumed/copied into other repositories.

Changes:

  • Add eng/common/.gitignore to ignore node_modules/ under eng/common.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Feb 28, 2026
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#14227 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-rust that referenced this pull request Feb 28, 2026
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#14227 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
@mikeharder mikeharder merged commit 8b59c22 into Azure:main Feb 28, 2026
7 checks passed
@mikeharder mikeharder deleted the eng-common-gitignore branch February 28, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants