Conversation
eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml
Outdated
Show resolved
Hide resolved
eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml
Outdated
Show resolved
Hide resolved
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
FixEngCommonWorkflowCheck
branch
from
278e89f to
c456cee
Compare
|
The following pipelines have been queued for testing: |
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Looks good but lets please test it out before merging.
I'll test it while calling it in the language repos |
| $filesInCommonDir = git diff "origin/$(System.PullRequest.TargetBranch)" HEAD --name-only -- 'eng/common/*' | ||
|
|
||
| if ((-not $PrSourceBranch.StartsWith("sync-eng/common")) -and ($filesInCommonDir.Count -gt 0)) | ||
| if ((!"$(System.PullRequest.SourceBranch)".StartsWith("sync-eng/common")) -and ($LASTEXITCODE -eq 0) -and ($filesInCommonDir.Count -gt 0)) |
There was a problem hiding this comment.
Will $LASTEXITCODE ever be hit? Wouldn't this script halt in devops if there's a non-zero exit code?
There was a problem hiding this comment.
git diff should set a lastexitcode but you are correct that maybe the error preferences devops uses might cause it to fail at that point. We'd have to test to know for sure but in either case I don't think it hurts to have the check.
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 4 participants
Fix error in eng-common-workflow-enforcer