Fix verify-links regex to handle repository URIs with .git suffix#13560
Merged
weshaggard merged 4 commits intomainfrom Jan 14, 2026
Merged
Fix verify-links regex to handle repository URIs with .git suffix#13560weshaggard merged 4 commits intomainfrom
weshaggard merged 4 commits intomainfrom
Conversation
Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix regex to handle source URIs ending with .git
Fix verify-links regex to handle repository URIs with .git suffix
Jan 13, 2026
weshaggard
reviewed
Jan 13, 2026
| function Test-ReplaceGithubLink { | ||
| param( | ||
| [string]$originLink, | ||
| [string]$branchReplaceRegex, |
Member
There was a problem hiding this comment.
@copilot default the shared regex here instead of duplicating it in all the tests.
Contributor
Author
There was a problem hiding this comment.
Done in commit 92bdf41. The shared regex pattern with optional .git suffix is now defined as $defaultRegex in the BeforeAll block and reused throughout the tests.
Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Member
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weshaggard
reviewed
Jan 13, 2026
Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Member
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced Jan 14, 2026
This was referenced Jan 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the verify-links pipeline where repository URIs ending with .git were not being handled correctly by the branch replacement regex pattern.
Changes:
- Updated the
BranchReplaceRegexpattern in verify-links.yml to handle optional.gitsuffix - Added comprehensive Pester tests to validate the fix for various scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/pipelines/templates/steps/verify-links.yml | Updated regex pattern to make .git suffix optional using (?:\\.git)? |
| eng/common-tests/Verify-Links-ReplaceGithubLink.Tests.ps1 | Added comprehensive test suite covering scenarios with and without .git suffix |
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jan 14, 2026
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13560 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
azure-sdk
added a commit
to Azure/azure-sdk-for-rust
that referenced
this pull request
Jan 14, 2026
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13560 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
chlowell
pushed a commit
to Azure/azure-sdk-for-rust
that referenced
this pull request
Jan 16, 2026
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13560 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitsuffix in source repository URIs.gitsuffixOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.