[azsdkcli] case insensitivity in Scanpath#13505
Merged
l0lawrence merged 9 commits intoAzure:mainfrom Jan 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes case insensitivity issues with ScanPath in the readme validation tool. Copilot was passing paths with lowercase drive letters (e.g., "c:") which caused failures in doc-warden's ScanPath validation.
Key changes:
- Normalizes package paths using
Path.GetFullPath()and ensures uppercase drive letters on Windows - Updates CHANGELOG to document the bug fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/azsdk-cli/Azure.Sdk.Tools.Cli/Helpers/CommonLanguageHelpers.cs | Adds path normalization logic to ensure uppercase drive letters on Windows before passing to ValidateReadme PowerShell script |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli/CHANGELOG.md | Documents the bug fix in the unreleased version section |
benbp
approved these changes
Jan 9, 2026
timovv
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot for in some cases was passing paths with "c:", which was then causing failures with ScanPath in readme validation --
open to suggestions on resolution here
doc-warden scanPaths are having issues with case insensitivity for some reason -> will investigate fixing there but this resolves #13426 for now