Skip to content

[azsdkcli] case insensitivity in Scanpath#13505

Merged
l0lawrence merged 9 commits intoAzure:mainfrom
l0lawrence:readmeoutput
Jan 12, 2026
Merged

[azsdkcli] case insensitivity in Scanpath#13505
l0lawrence merged 9 commits intoAzure:mainfrom
l0lawrence:readmeoutput

Conversation

@l0lawrence
Copy link
Member

@l0lawrence l0lawrence commented Jan 8, 2026

Copilot for in some cases was passing paths with "c:", which was then causing failures with ScanPath in readme validation --
open to suggestions on resolution here

doc-warden scanPaths are having issues with case insensitivity for some reason -> will investigate fixing there but this resolves #13426 for now

@github-actions github-actions bot added the azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli label Jan 8, 2026
@l0lawrence l0lawrence marked this pull request as ready for review January 8, 2026 19:57
@l0lawrence l0lawrence requested a review from a team as a code owner January 8, 2026 19:57
Copilot AI review requested due to automatic review settings January 8, 2026 19:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes case insensitivity issues with ScanPath in the readme validation tool. Copilot was passing paths with lowercase drive letters (e.g., "c:") which caused failures in doc-warden's ScanPath validation.

Key changes:

  • Normalizes package paths using Path.GetFullPath() and ensures uppercase drive letters on Windows
  • Updates CHANGELOG to document the bug fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Helpers/CommonLanguageHelpers.cs Adds path normalization logic to ensure uppercase drive letters on Windows before passing to ValidateReadme PowerShell script
tools/azsdk-cli/Azure.Sdk.Tools.Cli/CHANGELOG.md Documents the bug fix in the unreleased version section

Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this #13426!

@l0lawrence l0lawrence merged commit caa8fd6 into Azure:main Jan 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Bash] Readme validation showing incorrect results

4 participants