examples-automation, special handling for azure-resourcemanager at tsp #13447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Here is another incentive to see if we'd move the samples back to its lib (instead of in azure-resourcemanager lib). This PR does not need to be merged, if we decided to do above. |
XiaofeiCao
approved these changes
Jan 5, 2026
weidongxu-microsoft
force-pushed
the
examples-automation_java-fix-example-location-from-tsp
branch
from
e62f6a1 to
bc20257
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds special handling for the azure-resourcemanager library to correctly resolve example file paths from TypeSpec-generated incomplete paths to complete Swagger specification paths. The implementation extracts the service name from the sample file path and constructs the correct SDK package path to find the tsp-location.yaml file.
Changes:
- Modified the example processing logic to handle azure-resourcemanager package specially by extracting service names from file paths
- Added comprehensive test coverage for the new azure-resourcemanager handling scenario
- Increased the release window from 10 to 15 days in the automation pipeline
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/azure-rest-api-specs-examples-automation/samples-automation.yml | Increased release window from 10 to 15 days |
| tools/azure-rest-api-specs-examples-automation/java/test_process.py | Added test case and mock setup for azure-resourcemanager package handling |
| tools/azure-rest-api-specs-examples-automation/java/main.py | Implemented special path resolution logic for azure-resourcemanager packages |
XiaofeiCao
approved these changes
Feb 2, 2026
weidongxu-microsoft
deleted the
examples-automation_java-fix-example-location-from-tsp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure-resourcemanager lib need a special handling for getting an example from complete Swagger filename from an incomplete TypeSpec filename.
e.g. from
2025-05-01/listSecrets.jsontospecification/keyvault/resource-manager/Microsoft.KeyVault/stable/2025-05-01/examples/listSecrets.json