Skip to content

fixCheckErrors noop #13328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
l0lawrence wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fixCheckErrors noop #13328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7a5718
fix mode noop
l0lawrence Dec 11, 2025
0cb53ea
changelog
l0lawrence Dec 11, 2025
4c47499
here too
l0lawrence Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/azsdk-cli/Azure.Sdk.Tools.Cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

### Other Changes

- `noop` for methods where fixCheckErrors isn't fully supported if set to True for clarity

## 0.5.10 (2025-12-08)

### Features Added
Expand Down
10 changes: 10 additions & 0 deletions tools/azsdk-cli/Azure.Sdk.Tools.Cli/Helpers/CommonLanguageHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ public async Task<PackageCheckResponse> ValidateChangelog(
bool fixCheckErrors = false,
CancellationToken ct = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for changelog validation.");
}

try
{
var (packageRepoRoot, errorResponse) = ValidatePackageAndDiscoverRepo(packagePath);
Expand Down Expand Up @@ -128,6 +133,11 @@ public async Task<PackageCheckResponse> ValidateReadme(
bool fixCheckErrors = false,
CancellationToken ct = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for README validation.");
}

try
{
var (packageRepoRoot, errorResponse) = ValidatePackageAndDiscoverRepo(packagePath);
Expand Down
10 changes: 10 additions & 0 deletions tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/DotNetLanguageService.Checks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ public partial class DotnetLanguageService : LanguageService
{
public override async Task<PackageCheckResponse> CheckGeneratedCode(string packagePath, bool fixCheckErrors = false, CancellationToken ct = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for generated code checks.");
}

try
{
logger.LogInformation("Starting generated code checks for .NET project at: {PackagePath}", packagePath);
Expand Down Expand Up @@ -62,6 +67,11 @@ public override async Task<PackageCheckResponse> CheckGeneratedCode(string packa

public override async Task<PackageCheckResponse> CheckAotCompat(string packagePath, bool fixCheckErrors = false, CancellationToken ct = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for AOT compatibility checks.");
}

try
{
logger.LogInformation("Starting AOT compatibility check for .NET project at: {PackagePath}", packagePath);
Expand Down
5 changes: 5 additions & 0 deletions tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/GoLanguageService.Checks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,11 @@ public async Task<string> GetSDKPackageName(string repo, string packagePath, Can

public override async Task<PackageCheckResponse> UpdateSnippets(string packagePath, bool fixCheckErrors = false, CancellationToken cancellationToken = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for snippet updates in Go.");
}

return await Task.FromResult(new PackageCheckResponse());
}

Expand Down
10 changes: 10 additions & 0 deletions tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/JavaLanguageService.Checks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,11 @@ public override async Task<PackageCheckResponse> LintCode(string packagePath, bo

public override async Task<PackageCheckResponse> UpdateSnippets(string packagePath, bool fixCheckErrors = false, CancellationToken cancellationToken = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for snippet updates in Java.");
}

try
{
logger.LogInformation("Starting code snippet update for Java project at: {PackagePath}", packagePath);
Expand Down Expand Up @@ -265,6 +270,11 @@ public override async Task<PackageCheckResponse> UpdateSnippets(string packagePa

public override async Task<PackageCheckResponse> AnalyzeDependencies(string packagePath, bool fixCheckErrors = false, CancellationToken cancellationToken = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for dependency analysis in Java.");
}

try
{
logger.LogInformation("Starting dependency analysis for Java project at: {PackagePath}", packagePath);
Expand Down
10 changes: 10 additions & 0 deletions tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/JavaScriptLanguageService.Checks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ public partial class JavaScriptLanguageService : LanguageService

public async Task<PackageCheckResponse> ValidateSamplesAsync(string packagePath, bool fixCheckErrors = false, CancellationToken ct = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for sample validation in JavaScript.");
}

try
{
var result = await processHelper.Run(new(
Expand Down Expand Up @@ -44,6 +49,11 @@ public async Task<PackageCheckResponse> ValidateSamplesAsync(string packagePath,

public override async Task<PackageCheckResponse> UpdateSnippets(string packagePath, bool fixCheckErrors = false, CancellationToken cancellationToken = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for snippet updates in JavaScript.");
}

try
{
var result = await processHelper.Run(new(
Expand Down
15 changes: 15 additions & 0 deletions tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/PythonLanguageService.Checks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ public partial class PythonLanguageService : LanguageService
{
public override async Task<PackageCheckResponse> UpdateSnippets(string packagePath, bool fixCheckErrors = false, CancellationToken cancellationToken = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for snippet updates in Python.");
}

try
{
logger.LogInformation("Starting snippet update for Python project at: {PackagePath}", packagePath);
Expand Down Expand Up @@ -56,6 +61,11 @@ public override async Task<PackageCheckResponse> UpdateSnippets(string packagePa

public override async Task<PackageCheckResponse> LintCode(string packagePath, bool fixCheckErrors = false, CancellationToken cancellationToken = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for code linting in Python.");
}

try
{
logger.LogInformation("Starting code linting for Python project at: {PackagePath}", packagePath);
Expand Down Expand Up @@ -103,6 +113,11 @@ public override async Task<PackageCheckResponse> LintCode(string packagePath, bo

public override async Task<PackageCheckResponse> FormatCode(string packagePath, bool fixCheckErrors = false, CancellationToken cancellationToken = default)
{
if (fixCheckErrors)
{
return new PackageCheckResponse(0, "noop", "Fix mode is not supported for code formatting in Python.");
}

try
{
logger.LogInformation("Starting code formatting for Python project at: {PackagePath}", packagePath);
Expand Down