Ensure that we still use base-upstream if present in standard proxy mode #12621
Merged
Ensure that we still use base-upstream if present in standard proxy mode #12621
base-upstream if present in standard proxy mode #12621Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of the x-recording-upstream-base-uri header in standard proxy mode. Previously, the header was only retrieved and used in non-standard modes. The change ensures that if the header is present, it will be used regardless of the proxy mode, while maintaining the standard mode fallback behavior when the header is absent.
Key Changes:
- Moved header retrieval to occur before the mode check
- Modified the standard mode condition to only apply when the header is not present
benbp
approved these changes
Oct 22, 2025
github-project-automation
bot
moved this from 🤔 Triage
to 🔬 Dev in PR
in Azure SDK EngSys 📆🎇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.