Skip to content

validation running prompt #12531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
praveenkuttappan merged 11 commits into from
Nov 3, 2025
Merged

validation running prompt #12531

praveenkuttappan merged 11 commits into from
Nov 3, 2025

Conversation

@l0lawrence
Copy link
Member

@l0lawrence l0lawrence commented Oct 16, 2025 •
edited
Loading

Will add to each copilot-instructions:

# Check PR and Validation Checks of SDK
Run [check package validation](..\eng\common\instructions\azsdk-tools\check-package-validation.instructions.md) to check if the package validation has passed for the SDK package.

prompt: Run all PR checks locally for the Health Deidentification SDKs before I create pull requests.
Outputs:

image

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 16, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@l0lawrence l0lawrence changed the title prompt validation running Oct 20, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 20, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@l0lawrence l0lawrence changed the title validation running validation running prompt Oct 20, 2025
@l0lawrence l0lawrence mentioned this pull request Oct 20, 2025
Closed
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 20, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@l0lawrence l0lawrence marked this pull request as ready for review October 21, 2025 20:42
Copilot AI review requested due to automatic review settings October 21, 2025 20:42
Copilot AI reviewed Oct 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new instruction file for checking package validation in Azure SDK packages. The instruction file guides Copilot through collecting package information from users and running validation checks.

Key Changes:

  • New instruction file for package validation checking workflow
  • Supports multiple programming languages (Python, Java, JavaScript, .NET, Go)
  • Defines check types including linting, format, changelog, cspell, and readme

samvaity
samvaity reviewed Oct 22, 2025
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 23, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

timovv
timovv approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@timovv timovv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, we can adjust based on how it performs in practice

@ronniegeraghty ronniegeraghty added the azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli label Oct 23, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 23, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 31, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 31, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Nov 3, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 3, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Nov 3, 2025
@azure-sdk @l0lawrence @benbp
Sync eng/common directory with azure-sdk-tools for PR 12531 (#36425)
4219296 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#12531 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: l0lawrence <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
azure-sdk added a commit to Azure/azure-sdk-for-rust that referenced this pull request Nov 3, 2025
@azure-sdk @l0lawrence @benbp
Sync eng/common directory with azure-sdk-tools for PR 12531 (#3282)
fd9d532 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#12531 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: l0lawrence <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
@praveenkuttappan praveenkuttappan merged commit ec5d4ce into Azure:main Nov 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard left review comments

@m-redding m-redding m-redding left review comments

Copilot code review Copilot Copilot left review comments

@benbp benbp benbp approved these changes

@timovv timovv timovv approved these changes

@praveenkuttappan praveenkuttappan praveenkuttappan approved these changes

@maririos maririos Awaiting requested review from maririos maririos is a code owner

@MrJustinB MrJustinB Awaiting requested review from MrJustinB MrJustinB is a code owner

@samvaity samvaity Awaiting requested review from samvaity

Assignees

No one assigned

Labels

azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@l0lawrence @azure-sdk @benbp @timovv @weshaggard @maririos @samvaity @praveenkuttappan @m-redding @ronniegeraghty