Ensure that ApiChangeDetectRequestUrl always resolves#12451
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a conditional issue in the API change detection pipeline template to ensure the ApiChangeDetectRequestUrl variable is always set, even when previous steps have failed.
- Changed the condition from
succeeded()tosucceededOrFailed()to allow the step to run regardless of previous step outcomes
Collaborator
|
The following pipelines have been queued for testing: |
tjprescott
approved these changes
Oct 10, 2025
This was referenced Oct 10, 2025
weshaggard
approved these changes
Oct 10, 2025
scbedd
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Oct 10, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12451 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Scott Beddall <scbedd@microsoft.com>
scbedd
added a commit
to Azure/azure-sdk-for-rust
that referenced
this pull request
Oct 10, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12451 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Scott Beddall <scbedd@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing
succeedOrFailed().Failing PR build showing this behavior
Context conversation