package json get name for packages - js#12368
Merged
scbedd merged 16 commits intoAzure:mainfrom Oct 14, 2025
Merged
Conversation
l0lawrence
changed the title
github-actions
bot
added
the
azsdk-cli
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the GetSDKPackagePath method to read the package name from package.json for JavaScript packages instead of relying solely on directory names.
- Adds JSON parsing capability to extract package names from
package.jsonfiles - Implements fallback behavior to use directory names when JSON parsing fails or for non-JavaScript packages
- Includes error handling with logging for failed JSON parsing attempts
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/LanguageChecks.cs
Outdated
Show resolved
Hide resolved
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/LanguageChecks.cs
Outdated
Show resolved
Hide resolved
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/LanguageChecks.cs
Outdated
Show resolved
Hide resolved
timovv
reviewed
Oct 7, 2025
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/LanguageChecks.cs
Outdated
Show resolved
Hide resolved
l0lawrence
force-pushed
the
changelogfixjs
branch
from
e607a10 to
3b09a02
Compare
timovv
approved these changes
Oct 8, 2025
timovv
approved these changes
Oct 8, 2025
benbp
reviewed
Oct 8, 2025
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/JavaScriptLanguageSpecificChecks.cs
Outdated
Show resolved
Hide resolved
benbp
reviewed
Oct 8, 2025
l0lawrence
force-pushed
the
changelogfixjs
branch
from
87d502d to
4b94f28
Compare
richardpark-msft
approved these changes
Oct 9, 2025
Member
richardpark-msft
left a comment
richardpark-msft
left a comment
There was a problem hiding this comment.
Thank you for fixing my broken code :)
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/ILanguageSpecificChecks.cs
Outdated
Show resolved
Hide resolved
scbedd
requested changes
Oct 9, 2025
Member
scbedd
left a comment
scbedd
left a comment
There was a problem hiding this comment.
Move changelog update to unreleased 0.5.2 version instead of older 0.5.1.
benbp
reviewed
Oct 10, 2025
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/JavaScriptLanguageSpecificChecks.cs
Outdated
Show resolved
Hide resolved
l0lawrence
force-pushed
the
changelogfixjs
branch
from
4e8b6d6 to
cfb9f83
Compare
benbp
reviewed
Oct 13, 2025
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/JavaScriptLanguageSpecificChecks.cs
Outdated
Show resolved
Hide resolved
benbp
approved these changes
Oct 13, 2025
l0lawrence
force-pushed
the
changelogfixjs
branch
from
8eff87b to
3d07145
Compare
scbedd
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.