Refactoring common shared tools #1203
Conversation
| $apiUrl = "https://api.github.com/repos/$repoId" | ||
| $pkgs = VerifyPackages -pkgRepository $Repository ` | ||
| -artifactLocation $ArtifactLocation ` | ||
| $pkgs = VerifyPackages -artifactLocation $ArtifactLocation ` |
There was a problem hiding this comment.
Can we clean-up the $Repository variable?
There was a problem hiding this comment.
What is your plan to clean-up some of these unused variables we have as a parameter to this script like $Repository?
chidozieononiwu
force-pushed
the
feature/RefactorArtifact-metadata-parsing.ps1
branch
from
664105f to
647a9ca
Compare
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
The changes look good but lets please do some test releases of the template packages to ensure these changes work.
… and create-tags-and-git-release.ps1
chidozieononiwu
force-pushed
the
feature/RefactorArtifact-metadata-parsing.ps1
branch
from
5182cc7 to
bf1a37d
Compare
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
| Write-Host "Unrecognized Language: $language" | ||
| exit(1) | ||
| } | ||
| function GetMetaData { |
There was a problem hiding this comment.
I believe @sima-zhu has also defined this function somewhere we should probably move it to one our helper scripts so we can share it.
3 participants
Refactoring artifact-metadata-parsing.ps1, update-docs-metadata.ps1, and create-tags-and-git-release.ps1