Support standard proxy mode in test-proxy#11958
Merged
Conversation
…exercise the new stuff easily
…ow the routing is going to handle all this
… issue with key() value
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for standard proxy mode in the test-proxy tool, enabling it to function as a regular HTTP proxy without requiring special request headers. The implementation adds a new command-line flag --standard-proxy-mode and introduces universal recording endpoints that maintain global recording state instead of requiring session-specific headers.
- Adds
--standard-proxy-modecommand-line option to enable standard HTTP proxy behavior - Implements universal recording endpoints (
StartUniversal/StopUniversal) for simplified recording management - Adds middleware to handle absolute-form HTTP proxy requests and route them appropriately based on proxy mode
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| try-proxied-requests.ps1 | Updates test script to use standard proxy mode and universal recording endpoints |
| Startup.cs | Adds proxy configuration management and middleware for handling absolute-form requests |
| RecordingHandler.cs | Updates URI resolution logic to handle standard proxy requests vs legacy Azure mode |
| Record.cs | Adds universal recording endpoints and updates request handling for different proxy modes |
| launchSettings.json | Updates default launch configuration to use standard proxy mode |
| ServerRecordingConfiguration.cs | New model class defining proxy modes and recording configuration |
| StartOptions.cs | Adds StandardProxyMode property to command-line options |
| OptionsGenerator.cs | Adds --standard-proxy-mode command-line option definition |
benbp
reviewed
Sep 11, 2025
benbp
reviewed
Sep 11, 2025
benbp
reviewed
Sep 11, 2025
scbedd
commented
Sep 11, 2025
…ion except for more permissive network configuration.
This reverts commit 6bebcee. "# Please enter the commit message for your changes. Lines starting
benbp
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of #6177
todo:
stopUniversalorstartUniversal. They're unnecessary given that we have the static configuration accessible fromstartup.cs