Remove invalid characters in basename sourced from username #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
added
the
Central-EngSys
benbp
requested review from
danieljurek,
heaths and
weshaggard
as code owners
heaths
approved these changes
Nov 11, 2020
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced Nov 11, 2020
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
benbp
added a commit
that referenced
this pull request
Dec 1, 2020
Fixes #1189 This fixes a bug where a username may contain spaces or other invalid characters, e.g. ``` (py39_new) PS C:\github.com\azure-sdk-for-python> .\eng\common\TestResources\New-TestResources.ps1 'schemaregistry' New-TestResources.ps1: The variable cannot be validated because the value Sean Kaneschemaregistry is not a valid value for the BaseName variable. ```
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1189
This fixes a bug where a username may contain spaces or other invalid characters, e.g.