Skip to content

Handle JS packages with prefix @microsoft#1187

Closed
praveenkuttappan wants to merge 1 commit intoAzure:masterfrom
praveenkuttappan:feature/changelog_js_check
Closed

Handle JS packages with prefix @microsoft#1187
praveenkuttappan wants to merge 1 commit intoAzure:masterfrom
praveenkuttappan:feature/changelog_js_check

Conversation

@praveenkuttappan
Copy link
Copy Markdown
Member

JS has renamed open telemetry package from @azure/monitor-opentelemetry-exporter to @microsoft/opentelemetry-exporter-azure-monitor in PR #12417 and this will require change in verify change log check and docs release.

@praveenkuttappan
Copy link
Copy Markdown
Member Author

I will wait until Nov release is over to merge this change to all repos. @weshaggard: JS team needs this change to release opentelemetry package in November release. Can I make this change temporarily only in JS repo?

@praveenkuttappan
Copy link
Copy Markdown
Member Author

@xirzec : FYI. This is the PR to resolve change log check error for open telemetry and to handle rename of package from @ azure to @ microsoft

@sima-zhu
Copy link
Copy Markdown
Contributor

FYI, there are several places for doc needs to corporate with the changes.
Could you please check JS Language-Setting.ps1 and main.js

@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

{
$projectJson = Get-Content $projectPath | ConvertFrom-Json
$jsStylePkgName = $pkgName.replace("azure-", "@azure/")
$jsStylePkgName = ""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this code is used any more. You should be able to update https://github.com/Azure/azure-sdk-for-js/blob/master/eng/scripts/Language-Settings.ps1.

@praveenkuttappan
Copy link
Copy Markdown
Member Author

Closing this PR. I have submitted another one with changes in JS repo only. Azure/azure-sdk-for-js#12458

sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
* Update link to point to cmake options.

* Consistent capitalization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants